Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify --plat-name for macosx wheels #1311

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Modify --plat-name for macosx wheels #1311

merged 2 commits into from
Feb 13, 2021

Conversation

kvignesh1420
Copy link
Member

This PR updates the --plat-name from macosx_10_13_x86_64 to macosx_10_15_x86_64 while building the tfio wheel as per the github actions env.

@kvignesh1420 kvignesh1420 changed the title Macos version fix Modify --plat-name for macosx wheels Feb 13, 2021
@yongtang
Copy link
Member

@kvignesh1420 While GitHub Actions have macos 10.15, we actually limit the macOS binary compatibility to 10.14 (used to be 10.13):
https://github.com/tensorflow/io/blob/master/tools/build/configure.py#L122-L123

In GitHub Actions we limit to 10.13 in the past to allow the binaries we built could run on lower versions of macOS (not just 10.15).

If we want to change the --plat-name, maybe we can change to 10.14 instead (and drop the 10.13 support)?

@kvignesh1420
Copy link
Member Author

@yongtang yes sure, made the change.

@yongtang yongtang merged commit a59fac2 into tensorflow:master Feb 13, 2021
@kvignesh1420 kvignesh1420 deleted the macos-version-fix branch February 13, 2021 20:07
i-ony pushed a commit to i-ony/io that referenced this pull request Mar 8, 2021
* modify --plat-name for macosx wheels

* switch to 10.14
michaelbanfield pushed a commit to michaelbanfield/io that referenced this pull request Mar 30, 2021
* modify --plat-name for macosx wheels

* switch to 10.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants