Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HDF5 Files: Work in Progress #217

Closed
wants to merge 4 commits into from

Conversation

captain-pool
Copy link

cc: @yongtang

@captain-pool captain-pool changed the title Tfio hdf5: Work in Progress Support for HDF5 Files: Work in Progress May 5, 2019
@yongtang
Copy link
Member

yongtang commented May 5, 2019

There are some work need to be done. We could start with lint and python API first.

@yongtang
Copy link
Member

yongtang commented May 5, 2019

For lint:
If you have docker installed, can you run the following command:

docker run -i -t --rm -v $PWD:/v -w /v --net=host golang:1.12 bash -x -e -c 'go get github.com/bazelbuild/buildtools/buildifier && buildifier $(find . -type f \( -name WORKSPACE -or -name BUILD -or -name *.BUILD \))'

@yongtang
Copy link
Member

yongtang commented May 5, 2019

The dataset field effectively are column labels which could be similar to parquet or csv with df concept. A new field selection will be needed to make it work. You can try hard code one to make the program build.

I will update the API shortly to make the selection of data fields available.

@yongtang
Copy link
Member

yongtang commented May 6, 2019

@captain-pool PR #219 has been merged. It adds the columns field which will allow you to specify the dataset for output in hdf5.

@captain-pool
Copy link
Author

@captain-pool PR #219 has been merged. It adds the columns field which will allow you to specify the dataset for output in hdf5.

Hey @yongtang Thanks for the Update. Can you give me some example related to it?

@captain-pool
Copy link
Author

For lint:
If you have docker installed, can you run the following command:

docker run -i -t --rm -v $PWD:/v -w /v --net=host golang:1.12 bash -x -e -c 'go get github.com/bazelbuild/buildtools/buildifier && buildifier $(find . -type f \( -name WORKSPACE -or -name BUILD -or -name *.BUILD \))'

Done!

@captain-pool
Copy link
Author

@captain-pool PR #219 has been merged. It adds the columns field which will allow you to specify the dataset for output in hdf5.

Hey @yongtang Thanks for the Update. Can you give me some example related to it?

Nevermind!
Thanks for adding the support!

@yongtang
Copy link
Member

yongtang commented May 9, 2019

@captain-pool I think you can rebase against the master to have the ReadRecord in, then add additional tests in tests/test_hdf5.py.

@yongtang
Copy link
Member

yongtang commented Jun 2, 2019

@captain-pool It seems this PR is stalled. I will close the PR for now, but please reopen if merge conflicts have been resolved, and thanks for your contribution.

@yongtang yongtang closed this Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants