Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom gradient lookup bug #512

Merged

Conversation

karllessard
Copy link
Collaborator

The original code was doing the lookup on the node name, not the node type.

  • clean up in Bazel scripts

@karllessard karllessard requested a review from Craigacp January 15, 2024 21:50
@karllessard karllessard force-pushed the bazelcism-with-gradients branch from de2733d to e73e472 Compare January 15, 2024 21:52
Copy link
Collaborator

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karllessard karllessard merged commit f6acf31 into tensorflow:bazelcism Jan 16, 2024
1 check passed
karllessard added a commit that referenced this pull request Feb 23, 2024
* Bazel script cleanup

* Fix custom gradient lookup issue
karllessard added a commit that referenced this pull request Feb 24, 2024
* Bazel script cleanup

* Fix custom gradient lookup issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants