Adding a control dependency on the gradients to the gradient optimizers #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs. This improves determinism and makes the gradients be computed correctly for unclear reasons.
karllessard
approved these changes
Feb 17, 2024
karllessard
pushed a commit
that referenced
this pull request
Feb 17, 2024
This improves determinism and makes the gradients be computed correctly for unclear reasons. (#520) Co-authored-by: Nicolas Feybesse (nfeybesse@users.noreply.github.com)
karllessard
pushed a commit
that referenced
this pull request
Feb 23, 2024
This improves determinism and makes the gradients be computed correctly for unclear reasons. (#520) Co-authored-by: Nicolas Feybesse (nfeybesse@users.noreply.github.com)
karllessard
pushed a commit
that referenced
this pull request
Feb 24, 2024
This improves determinism and makes the gradients be computed correctly for unclear reasons. (#520) Co-authored-by: Nicolas Feybesse (nfeybesse@users.noreply.github.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves determinism and makes the gradients be computed correctly. As it's a control dependency on all the gradients to the consumers of the gradients it's not clear why this is necessary, but it's working.
Fix developed by @nfeybesse.