Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2_utils_2x_wide.py cleanup #11122

Merged
5 commits merged into from
Feb 9, 2024

Conversation

redwrasse
Copy link
Contributor

Description

📝 Please include a summary of the change.

  • Miscellaneous cleanup of tf2_utils_2x_wide.py, and adds test_relations unit test.
  • No additional dependencies required.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Other (misc cleanup and test added)

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Test Configuration:

tf2_utils_2x_wide_test.py unit tests passed.

Checklist

@redwrasse redwrasse changed the title tf2_2x_wide_cleanup tf2_utils_2x_wide.py cleanup Dec 1, 2023
@laxmareddyp laxmareddyp requested review from Chen-Zhe and removed request for saberkun and rachellj218 December 1, 2023 16:13
@gbaned gbaned added the models:official models that come under official repository label Jan 9, 2024
@laxmareddyp laxmareddyp requested review from Zarjagen, yeqingli and fyangf and removed request for Chen-Zhe and Zarjagen January 18, 2024 18:31
@baek-jinoo baek-jinoo added the ready to pull ready to pull (create internal pr review and merge automatically) label Jan 20, 2024
@laxmareddyp
Copy link
Collaborator

Hi @redwrasse,

Could you please make changes as suggested above.Thanks

@laxmareddyp laxmareddyp removed the ready to pull ready to pull (create internal pr review and merge automatically) label Jan 23, 2024
@baek-jinoo baek-jinoo added the ready to pull ready to pull (create internal pr review and merge automatically) label Jan 23, 2024
@sineeli sineeli removed the request for review from fyangf January 23, 2024 18:48
@sineeli sineeli added ready to pull ready to pull (create internal pr review and merge automatically) and removed ready to pull ready to pull (create internal pr review and merge automatically) labels Jan 23, 2024
@laxmareddyp laxmareddyp added ready to pull ready to pull (create internal pr review and merge automatically) and removed ready to pull ready to pull (create internal pr review and merge automatically) labels Jan 24, 2024
@laxmareddyp laxmareddyp added ready to pull ready to pull (create internal pr review and merge automatically) and removed ready to pull ready to pull (create internal pr review and merge automatically) labels Jan 25, 2024
@sineeli sineeli added ready to pull ready to pull (create internal pr review and merge automatically) and removed ready to pull ready to pull (create internal pr review and merge automatically) labels Feb 1, 2024
copybara-service bot pushed a commit that referenced this pull request Feb 9, 2024
@copybara-service copybara-service bot closed this pull request by merging all changes into tensorflow:master in 030e22c Feb 9, 2024
@redwrasse redwrasse deleted the redwrasse/tf2_utils_2x_wide_cleanup branch February 10, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:official models that come under official repository ready to pull ready to pull (create internal pr review and merge automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants