Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval summary argument to fix notebook breakage #11152

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Jan 29, 2024

Description

Current Notebook is breaking as evaluation summary with image is by default True so passing eval summary argument will solve the issue.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

  • Bug fix (non-breaking change which fixes an issue)

Tests

Test Configuration:

Checklist

@sineeli sineeli requested a review from a team as a code owner January 29, 2024 19:46
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@laxmareddyp laxmareddyp requested review from fyangf and removed request for a team January 29, 2024 19:52
@laxmareddyp laxmareddyp added the ready to pull ready to pull (create internal pr review and merge automatically) label Jan 29, 2024
@sineeli sineeli added ready to pull ready to pull (create internal pr review and merge automatically) and removed ready to pull ready to pull (create internal pr review and merge automatically) labels Feb 1, 2024
@laxmareddyp laxmareddyp added the models:official models that come under official repository label Feb 1, 2024
@copybara-service copybara-service bot merged commit e01ad92 into master Feb 2, 2024
7 of 8 checks passed
copybara-service bot pushed a commit that referenced this pull request Feb 2, 2024
@sineeli sineeli deleted the sineeli-patch-16 branch March 7, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:official models that come under official repository ready to pull ready to pull (create internal pr review and merge automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants