Made api's compatible with python3.7+ #11259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatjetti
requested review from
yeqingli,
rachellj218 and
lehougoogle
as code owners
laxmareddyp
requested review from
Chen-Zhe
and removed request for
rachellj218
This was referenced Sep 16, 2024
|
Hi @yeqingli, @lehougoogle, @Chen-Zhe, could you please review the PR. Thank You |
Chen-Zhe
previously approved these changes
Oct 3, 2024
laxmareddyp
added
the
ready to pull
laxmareddyp
removed
the
ready to pull
yeqingli
reviewed
Oct 23, 2024
| @@ -33,7 +34,7 @@ class BaseTwoTowerUpliftNetwork(tf_keras.layers.Layer, metaclass=abc.ABCMeta): | |||
| def call( | |||
| self, | |||
| inputs: types.DictOfTensors, | |||
| training: bool | None = None, | |||
| mask: tf.Tensor | None = None, | |||
| training: Union[bool, None] = None, | |||
There was a problem hiding this comment.
I think Union[something | None] is equivalent to Optional[something]. Could you update here and all the other places if applicable.
yeqingli
reviewed
Oct 29, 2024
official/vision/modeling/factory.py
Outdated
| @@ -263,8 +263,8 @@ def build_retinanet( | |||
| l2_regularizer: Optional[tf_keras.regularizers.Regularizer] = None, | |||
| backbone: Optional[tf_keras.Model] = None, | |||
| decoder: Optional[tf_keras.Model] = None, | |||
| num_anchors_per_location: int | dict[str, int] | None = None, | |||
| anchor_boxes: Mapping[str, tf.Tensor] | None = None, | |||
| num_anchors_per_location: Union[int, Dict[str, int], None] = None, | |||
There was a problem hiding this comment.
Can this Union[int, Dict[str, int], None] be Optional[Union[int, Dict[str, int]]]
chaoyan1037
reviewed
Nov 18, 2024
chaoyan1037
reviewed
Nov 18, 2024
chaoyan1037
reviewed
Nov 18, 2024
|
Please resolve conflicts. |
Resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference github issue #11247 #11256
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist