Add a workspace name #51
Conversation
|
Can one of the admins verify this patch? |
|
@tensorflow-jenkins: test this please |
|
Thanks! Looks good, could you please squash commits? |
|
Done. |
|
@tensorflow-jenkins: test this please |
|
Seems Jenkins fails to find half_plus_two in the new directory. Is Could not find base path: /var/lib/jenkins/workspace/serving-pull-request-cpu/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/workspace/bazel-out/local_linux-fastbuild/bin/tensorflow_serving/servables/tensorflow/simple_servers_test.runfiles/org_tensorflow_serving/tensorflow_serving/session_bundle/example/half_plus_two |
|
Ugh, I think I know what this is. Bazel isn't properly noticing that the runfiles directory has changed. I might have to make a fix Bazel before this can be pushed, let me verify. |
|
@tensorflow-jenkins: test this please |
|
GitHub hasn't gotten the fix yet (although it should in a few minutes). |
|
I thought the only fix needed is to run 'bazel clean' so I updated our Jenkins config. We're still using the predefined bazel version (0.2.0) so we won't pull in changes to Github (to bazel if that's what you meant), or did you mean you updated the PR and just haven't pushed the changes to github? |
|
Ah, I thought you were pulling from Bazel's head. Cool! This should work, then, if it wiped out the existing output directories. |
|
@tensorflow-jenkins: test this please |
| #include "tensorflow/core/platform/test.h" | ||
|
|
||
| namespace tensorflow { | ||
| namespace serving { | ||
| namespace test_util { | ||
|
|
||
| string TestSrcDirPath(const string& relative_path) { | ||
| string base_path = tensorflow::io::JoinPath( |
|
@tensorflow-jenkins: test this please |
| @@ -1,3 +1,5 @@ | |||
| workspace(name = "org_tensorflow_serving") | |||
There was a problem hiding this comment.
Thanks so much for your patience with this. After some more thought, can we make this workspace name "tf_serving"? This simplifies some things for us and keeps the name short.
There was a problem hiding this comment.
Workspace names are supposed to be in reverse domain name form, so I don't think tf_serving really makes sense.
There was a problem hiding this comment.
Talked with @damienmg and we decided to encourage but not enforce this in Bazel projects. Changed.
Bazel is going to be restructuring the runfiles tree (see https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure) for details), which requires all projects to have a workspace name (__main__ will be used if one is not provided). Feel free to suggest a different name if you guys prefer, but something needs to be set or the tests will break when Bazel starts using the new runfiles tree structure. Change workspace name to org_tensorflow_serving
Bazel is going to be restructuring the runfiles tree (see
https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure
for details), which requires all projects to have a workspace name
(
__main__will be used if one is not provided).Feel free to suggest a different name if you guys prefer, but something
needs to be set or the tests will break when Bazel starts using the new
runfiles tree structure.