Skip to content

Commit

Permalink
Remove some broken demos and demo annotations
Browse files Browse the repository at this point in the history
Summary:
Some modules have `@demo` annotations that point to nonexistent demos,
so we fix or remove those references as appropriate.

The `google-chart` demo is not working and does not appear to have ever
worked: when running it on its initial commit after cherry-picking #1334
we see only a blank page. However, deleting this demo isn’t trivial,
because the main profile dashboard depends on it for some reason. As
this plugin is still being actively developed, we’ll leave the demo
alone for now: it’s not actually causing any problems.

Context: <#1645 (comment)>

Test Plan:
Note that `git grep @demo` only lists correct paths to working demos.

wchargin-branch: remove-broken-demos
  • Loading branch information
wchargin committed Nov 29, 2018
1 parent 4991e24 commit 28de034
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
such as different X scales (linear and temporal), tooltips and smoothing.
@element vz-line-chart
@demo demo/index.html
-->
<dom-module id="vz-chart-tooltip">
<template>
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/components/vz_line_chart/vz-line-chart.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
such as different X scales (linear and temporal), tooltips and smoothing.
@element vz-line-chart
@demo demo/index.html
@demo index.html
-->
<dom-module id="vz-line-chart">
<template>
Expand Down
1 change: 0 additions & 1 deletion tensorboard/components/vz_line_chart2/vz-line-chart2.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
such as different X scales (linear and temporal), tooltips and smoothing.
@element vz-line-chart
@demo demo/index.html
-->
<dom-module id="vz-line-chart2">
<template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
visualization.
@element vz-histogram-timeseries
@demo demo/index.html
@demo index.html
-->
<dom-module id="vz-histogram-timeseries">
<template>
Expand Down
2 changes: 0 additions & 2 deletions tensorboard/plugins/profile/google_chart/google-chart.html
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
on the `html` tag of your document.
<html lang="ja">
@demo
-->
<dom-module id="google-chart">
<template>
Expand Down

0 comments on commit 28de034

Please sign in to comment.