Skip to content

Commit

Permalink
fix lint for 6883
Browse files Browse the repository at this point in the history
  • Loading branch information
rileyajones committed Jul 17, 2024
1 parent 2c1934c commit 3d385cc
Show file tree
Hide file tree
Showing 15 changed files with 92 additions and 95 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ export class ExecutionDataContainer {
readonly debugTensorDtypes$;

constructor(private readonly store: Store<State>) {
this.focusedExecutionData$ = this.store.pipe(
select(getFocusedExecutionData),
this.focusedExecutionData$ = this.store.pipe(
select(getFocusedExecutionData)
);
this.tensorDebugMode$ = this.store.pipe(
select(
Expand All @@ -61,9 +61,9 @@ export class ExecutionDataContainer {
} else {
return execution.tensor_debug_mode;
}
},
),
),
}
)
)
);
this.hasDebugTensorValues$ = this.store.pipe(
select(
Expand All @@ -83,9 +83,9 @@ export class ExecutionDataContainer {
}
return false;
}
},
),
),
}
)
)
);
this.debugTensorValues$ = this.store.pipe(
select(
Expand All @@ -97,9 +97,9 @@ export class ExecutionDataContainer {
} else {
return execution.debug_tensor_values;
}
},
),
),
}
)
)
);
this.debugTensorDtypes$ = this.store.pipe(
select(
Expand All @@ -124,17 +124,17 @@ export class ExecutionDataContainer {
const dtypeEnum = String(
execution.tensor_debug_mode === TensorDebugMode.FULL_HEALTH
? tensorValue[2] // tensor_debug_mode: FULL_HEALTH
: tensorValue[1], // tensor_debug_mode: SHAPE
: tensorValue[1] // tensor_debug_mode: SHAPE
);
dtypes.push(
DTYPE_ENUM_TO_NAME[dtypeEnum] || UNKNOWN_DTYPE_NAME,
DTYPE_ENUM_TO_NAME[dtypeEnum] || UNKNOWN_DTYPE_NAME
);
}
}
return dtypes;
},
),
),
}
)
)
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {State as DebuggerState} from '../../store/debugger_types';
export class SourceFilesContainer {
constructor(private readonly store: Store<DebuggerState & OtherAppState>) {
this.focusedSourceFileContent$ = this.store.select(
getFocusedSourceFileContent,
getFocusedSourceFileContent
);
this.focusedSourceLineSpec$ = this.store.select(getFocusedSourceLineSpec);
this.useDarkMode$ = this.store.select(getDarkModeEnabled);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,16 @@ export class StackTraceContainer {
getCodeLocationOrigin,
(originInfo): CodeLocationType | null => {
return originInfo === null ? null : originInfo.codeLocationType;
},
),
),
}
)
)
);
this.opType$ = this.store.pipe(
select(
createSelector(getCodeLocationOrigin, (originInfo): string | null => {
return originInfo === null ? null : originInfo.opType;
}),
),
})
)
);
this.opName$ = this.store.pipe(
select(
Expand All @@ -90,8 +90,8 @@ export class StackTraceContainer {
return null;
}
return originInfo.opName;
}),
),
})
)
);
this.executionIndex$ = this.store.pipe(
select(
Expand All @@ -103,11 +103,11 @@ export class StackTraceContainer {
return null;
}
return originInfo.executionIndex;
}),
),
})
)
);
this.stickToBottommostFrameInFocusedFile$ = this.store.pipe(
select(getStickToBottommostFrameInFocusedFile),
select(getStickToBottommostFrameInFocusedFile)
);
this.stackFramesForDisplay$ = this.store.pipe(
select(
Expand All @@ -116,7 +116,7 @@ export class StackTraceContainer {
getFocusedSourceLineSpec,
(
stackFrames,
focusedSourceLineSpec,
focusedSourceLineSpec
): StackFrameForDisplay[] | null => {
if (stackFrames === null) {
return null;
Expand Down Expand Up @@ -145,9 +145,9 @@ export class StackTraceContainer {
});
}
return output;
},
),
),
}
)
)
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,11 @@ export class TimelineContainer {
select(
createSelector(getNumExecutionsLoaded, (loaded) => {
return loaded.state == DataLoadState.LOADING;
}),
),
})
)
);
this.scrollBeginIndex$ = this.store.pipe(
select(getExecutionScrollBeginIndex),
select(getExecutionScrollBeginIndex)
);
this.scrollBeginIndexUpperLimit$ = this.store.pipe(
select(
Expand All @@ -149,29 +149,29 @@ export class TimelineContainer {
getDisplayCount,
(numExecutions, displayCount) => {
return Math.max(0, numExecutions - displayCount);
},
),
),
}
)
)
);
this.pageSize$ = this.store.pipe(select(getExecutionPageSize));
this.displayCount$ = this.store.pipe(select(getDisplayCount));
this.displayExecutionDigests$ = this.store.pipe(
select(
createSelector(getVisibleExecutionDigests, (visibleDigests) => {
return visibleDigests.map((digest) =>
getExecutionDigestForDisplay(digest),
getExecutionDigestForDisplay(digest)
);
}),
),
})
)
);
this.displayFocusedAlertTypes$ = this.store.pipe(
select(getFocusAlertTypesOfVisibleExecutionDigests),
select(getFocusAlertTypesOfVisibleExecutionDigests)
);
this.focusedExecutionIndex$ = this.store.pipe(
select(getFocusedExecutionIndex),
select(getFocusedExecutionIndex)
);
this.focusedExecutionDisplayIndex$ = this.store.pipe(
select(getFocusedExecutionDisplayIndex),
select(getFocusedExecutionDisplayIndex)
);
this.numExecutions$ = this.store.pipe(select(getNumExecutions));
}
Expand Down
6 changes: 3 additions & 3 deletions tensorboard/webapp/core/views/page_title_container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class PageTitleContainer {
this.getExperimentId$ = this.store.select(getExperimentIdsFromRoute).pipe(
map((experimentIds) => {
return experimentIds?.[0];
}),
})
);
this.experimentName$ = this.getExperimentId$.pipe(
filter(Boolean),
Expand All @@ -82,7 +82,7 @@ export class PageTitleContainer {
// tslint:disable-next-line:deprecation
return this.store.select(getExperiment, {experimentId});
}),
map((experiment) => (experiment ? experiment.name : null)),
map((experiment) => (experiment ? experiment.name : null))
);
this.title$ = this.store.select(getEnvironment).pipe(
combineLatestWith(this.store.select(getRouteKind), this.experimentName$),
Expand All @@ -98,7 +98,7 @@ export class PageTitleContainer {
return tbBrandName;
}),
startWith(this.customBrandName || DEFAULT_BRAND_NAME),
distinctUntilChanged(),
distinctUntilChanged()
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ export class FeatureFlagModalTriggerContainer implements OnInit, OnDestroy {
private featureFlagsDialog?: MatDialogRef<FeatureFlagDialogContainer>;
private ngUnsubscribe = new Subject<void>();

constructor(
private readonly store: Store<State>,
private dialog: MatDialog
) {
constructor(private readonly store: Store<State>, private dialog: MatDialog) {
this.showFeatureFlags$ = this.store.select(getShowFlagsEnabled);
}

Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/header/dark_mode_toggle_container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class DarkModeToggleContainer {
return override
? DarkModeOverride.DARK_MODE_ON
: DarkModeOverride.DARK_MODE_OFF;
}),
})
);
}

Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/header/reload_container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class ReloadContainer {
combineLatestWith(this.reloadDisabled$),
map(([loadState, reloadDisabled]) => {
return !reloadDisabled && loadState === DataLoadState.LOADING;
}),
})
);
this.lastLoadedTimeInMs$ = this.store.select(getAppLastLoadedTimeInMs);
}
Expand Down
Loading

0 comments on commit 3d385cc

Please sign in to comment.