Skip to content

Commit

Permalink
Force protobuf dependency < 3.20. (#5726)
Browse files Browse the repository at this point in the history
The latest protobuf release is not backwards compatible with TensorFlow's protos and our copies of those protos in tensorboard/compat/proto . We knew this change was coming so, fortunately, TF had already fixed their dependencies to force a compatible version of protobuf. However, we also have to update our own requirements.txt to force the same version of protobuf, to unbreak the build when TensorFlow is not installed.

Googlers, see: http://b/182876485.
See: protocolbuffers/protobuf#9954 (comment)
See: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/tools/pip_package/setup.py?q=protobuf
  • Loading branch information
bmd3k authored May 26, 2022
1 parent 28ff87e commit fd4f5ff
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion tensorboard/pip_package/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ google-auth >= 1.6.3, < 3
google-auth-oauthlib >= 0.4.1, < 0.5
markdown >= 2.6.8
numpy >= 1.12.0
protobuf >= 3.9.2
# Protobuf 4.0 is incompatible with TF. Force < 3.20 until they unblock upgrade.
# See: http://b/182876485
# See: https://github.com/protocolbuffers/protobuf/issues/9954#issuecomment-1128283911
# See: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/tools/pip_package/setup.py?q=protobuf
protobuf >= 3.9.2, < 3.20
requests >= 2.21.0, < 3
setuptools >= 41.0.0
tensorboard-data-server >= 0.6.0, < 0.7.0
Expand Down

0 comments on commit fd4f5ff

Please sign in to comment.