Fixed the Projector infinite loop issue #1481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closure compilation is turned on, it uses prototype definitions to
mangle and optimize the calls. This made some method not defined
statically problematic and it seems to have turned
numeric.div
intosomething else.
According to numericjs, unlike other methods we use like dot and
transpose, is genearted dynamically from numeric.ops2 and Closure seems
to not handle it well.
https://github.com/sloisel/numeric/blob/master/src/numeric.js
Concretely, it turns numeric.div(a, b) into mangledName(numeric, a) and
this led division operation to infinitely loop.
In above code snippet,
Oa
is thediv
method.Fixes #1480