-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Upgrade FE dependencies #3232
Conversation
c3a93a6
to
30d0492
Compare
7dfcbd3
to
54ef412
Compare
The change is ready to be reviewed. Will update the TF cache when I get LGTM. |
f736faf
to
043f08b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -100,7 +100,6 @@ tf_ts_library( | |||
|
|||
tf_ts_devserver( | |||
name = "dev_server", | |||
index_html = "demo/demo.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that removing this was required when I was trying to do this upgrade too. Not blocking but cc @caisq in case this affects the devserver and it needs to be retooled at all to work again after this change.
Notable changes: - Angular 8 -> Angular 9 - zonejs upgrade - ngrx @ 9 - TypeScript @ 3.8.3 - Karma @ 5 - Angular Ivy compiler (ngcc) - Updated rules_nodejs to make it work with Ivy compiler - use node 11 in travis We used [1] as inspiration to our changes. Other notable changes: - window.require is frozen object after require.js upgrade [1]: https://github.com/bazelbuild/rules_nodejs/tree/master/examples/angular
Notable changes: Angular 8 -> Angular 9 zonejs upgrade ngrx @ 9 TypeScript @ 3.8.3 Karma @ 5 Angular Ivy compiler (ngcc) Updated rules_nodejs to make it work with Ivy compiler use node 11 in travis We used 1 as inspiration to our changes. Other notable changes: window.require is frozen object after require.js upgrade
Notable changes: Angular 8 -> Angular 9 zonejs upgrade ngrx @ 9 TypeScript @ 3.8.3 Karma @ 5 Angular Ivy compiler (ngcc) Updated rules_nodejs to make it work with Ivy compiler use node 11 in travis We used 1 as inspiration to our changes. Other notable changes: window.require is frozen object after require.js upgrade
Notable changes:
We used 1 as inspiration to our changes.
Other notable changes:
cc: @caisq