Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng: remove deprecated get and use inject #3603

Merged
merged 1 commit into from
May 7, 2020

Conversation

stephanwlee
Copy link
Contributor

In Angular 9, TestBed.get is deprecated 1 in favor of inject.
This change simply changes to use inject.

Fixes #3233.

In Angular 9, `TestBed.get` is deprecated [1] in favor of inject.
This change simply changes to use `inject`.

[1]: https://angular.io/api/core/testing/TestBed
Copy link
Contributor

@psybuzz psybuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and mechanical change lgtm!

@stephanwlee stephanwlee changed the title ng: remove deprecated and use ng: remove deprecated get and use inject May 7, 2020
@stephanwlee stephanwlee merged commit 9ab2cf9 into tensorflow:master May 7, 2020
@stephanwlee stephanwlee deleted the depre2 branch May 7, 2020 22:03
caisq pushed a commit to caisq/tensorboard that referenced this pull request May 19, 2020
In Angular 9, `TestBed.get` is deprecated [1] in favor of inject.
This change simply changes to use `inject`.

[1]: https://angular.io/api/core/testing/TestBed
caisq pushed a commit that referenced this pull request May 27, 2020
In Angular 9, `TestBed.get` is deprecated [1] in favor of inject.
This change simply changes to use `inject`.

[1]: https://angular.io/api/core/testing/TestBed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: migrate to TestBed.inject from TestBed.get
3 participants