Projector config at root becomes default config for any present runs #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
reviewed
May 20, 2020
nfelt
approved these changes
May 30, 2020
This was referenced Jul 16, 2020
psybuzz
added a commit
that referenced
this pull request
Jul 16, 2020
…runs" (#3850) This reverts commit 12f6234. The changes in [1] allowed TensorBoard to use the root directory's projector config and apply it to each subdirectory. If the root dir's config specifies a "sprite" that does not exist in every subdirectory, it causes the Projector frontend to hang when loading a run. See #3840 for details on the issue. Confirmed that this fixes the issue by running TB on a directory with: - ./projector_config.pbtxt ``` embeddings { tensor_name: "EMNIST_Letters:0" metadata_path: "metadata.tsv" sprite { image_path: "sprite.png" single_image_dim: 28 single_image_dim: 28 } } ``` - alongside a subdirectory `profile_demo_new` that contains a `.profile-empty` event file but no `sprite.png` file [1] #3653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update projector config to better handle multiple runs. If multiple runs are present, only one set of config/metadata needs to be present in the root directory, which will be used for any runs without config explicitly set.