Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Series: fix dark mode color #5426

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Time Series: fix dark mode color #5426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f388605
fix dark mode color
japie1235813 Nov 17, 2021
ef648a1
ac
japie1235813 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tensorboard/webapp/metrics/views/main_view/card_group_toolbar_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,16 @@ limitations under the License.
cursor: pointer;
}
}

@include tb-dark-theme {
.group-toolbar {
color: map-get($tb-dark-foreground, text);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, you are no longer allowed to use map-get.
Second: can you just do @include tb-theme-foreground-prop(color, text); in L24?


.expand-group-icon {
@include tb-theme-foreground-prop(color, secondary-text);
background-color: $metrics-button-background-color-on-gray;

&:disabled {
@include tb-theme-foreground-prop(color, disabled-text);
Expand Down