style: optimize paint by putting contain: strict
#5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that mouse move was causing large paints that it should not. Putting `contain: strict` which informs browser to put a bound to style calculation helped alleviate the issue. Repro: in time series dashboard, with "Rendering > Paint Flashing" option enabled, mouse move in the dashboard.
japie1235813
approved these changes
Dec 14, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Notice that mouse move was causing large paints that it should not. Putting `contain: strict` which informs browser to put a bound to style calculation helped alleviate the issue. Repro: in time series dashboard, with "Rendering > Paint Flashing" option enabled, mouse move in the dashboard.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Notice that mouse move was causing large paints that it should not. Putting `contain: strict` which informs browser to put a bound to style calculation helped alleviate the issue. Repro: in time series dashboard, with "Rendering > Paint Flashing" option enabled, mouse move in the dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that mouse move was causing large paints that it should not.
Putting
contain: strictwhich informs browser to put a bound to stylecalculation helped alleviate the issue.
Repro: in time series dashboard, with "Rendering > Paint Flashing"
option enabled, mouse move in the dashboard.