Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: adjust contain style to show the expander #5503

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

japie1235813
Copy link
Contributor

@japie1235813 japie1235813 commented Jan 14, 2022

When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage)

before
Screen Shot 2022-01-13 at 4 50 18 PM

after
Screen Shot 2022-01-13 at 4 43 25 PM

The contain style is used to optimize the rendering, indicating the element might be independent of the rest of the dom tree. But for the expander, the width can't be sized without its descendants' sizes (the icon). Updates the contain to remove size from the consideration. contain: content; is equivalent to contain: layout paint

Copy link
Contributor

@bmd3k bmd3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll cherry-pick this into the 2.8.0 release.

@japie1235813 japie1235813 merged commit c211512 into tensorflow:master Jan 14, 2022
bmd3k pushed a commit to bmd3k/tensorboard that referenced this pull request Jan 19, 2022
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
bmd3k pushed a commit that referenced this pull request Jan 20, 2022
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants