-
Notifications
You must be signed in to change notification settings - Fork 949
Add support for UNSIGNED_BYTE textures #109
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Reviewed 34 of 38 files at r5. src/environment.ts, line 34 at r5 (raw file):
change to 'writing and reading' src/environment.ts, line 123 at r5 (raw file):
not in this PR, but would be good to see if this catches safari desktop. you might need to call gl.readPixels to test src/test_util.ts, line 159 at r5 (raw file):
extract executor signature into a type src/math/math_test.ts, line 199 at r5 (raw file):
debug mode here and below src/math/pool_test.ts, line 179 at r5 (raw file):
math.minPool shows up twice, remove this block src/math/unaryop_test.ts, line 87 at r5 (raw file):
math.abs repeated.remove block Comments from Reviewable |
Review status: all files reviewed at latest revision, 6 unresolved discussions. Comments from Reviewable |
Review status: 29 of 34 files reviewed at latest revision, 6 unresolved discussions. src/environment.ts, line 34 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Done. src/environment.ts, line 123 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Added to my todo list. src/test_util.ts, line 159 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Done. src/math/math_test.ts, line 199 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Done. src/math/pool_test.ts, line 179 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Done. src/math/unaryop_test.ts, line 87 at r5 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Done. Comments from Reviewable |
This enables iOS.
We also add new unit test capability to run tests against multiple environment features.
This change is