Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop shelljs package from tfjs-node. #1691

Closed
nkreeger opened this issue Jun 24, 2019 · 0 comments
Closed

Drop shelljs package from tfjs-node. #1691

nkreeger opened this issue Jun 24, 2019 · 0 comments
Assignees

Comments

@nkreeger
Copy link
Contributor

nkreeger commented Jun 24, 2019

There is a security problem with shelljs and that package has not been published in 7 months.

It looks like we do this only for tensorboard tests - we can do these actions with existing Node.js APIs already:

src/tensorboard_test.ts:24:const shelljs = require('shelljs');
src/tensorboard_test.ts:37:      shelljs.rm('-rf', tmpLogDir);
src/tensorboard_test.ts:133:    shelljs.mkdir('-p', tmpLogDir);
src/tensorboard_test.ts:156:      shelljs.rm('-rf', tmpLogDir);
@nkreeger nkreeger self-assigned this Jun 24, 2019
nkreeger added a commit to tensorflow/tfjs-node that referenced this issue Jun 25, 2019
…s). (#264)

* Drop shelljs since it has a security issue (and no update for 6 months).

tensorflow/tfjs#1691

* Ignore tensorboard tests (for now) on win32.

* tensorboard and tensorBoard

* Windows cleanup message

* Add issue for reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant