Update installation steps for Windows / Mac OS X for tfjs-node in REA… #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
Jan 9, 2024
|
Hi @gaikwadrahul8 Your branch is out of date, can you please update your branch? Thank you! |
mattsoulanille
approved these changes
Apr 18, 2024
This was referenced May 31, 2024
Closed
This was referenced Jun 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated Windows / Mac OS X Requires Python 2.7 section of tfjs-node for installing which seems outdated and as per the official documentation of node-gyp, " node-gyp requires that you have installed a supported version of Python. " I recommend updating the
tfjs-nodedocumentation aligning it with node-gyp requirements. Please do the needful or I welcome any suggestions or feedback to update outdatedtfjs-nodeofficial documentation from your end. Thank you.Addressing this issue will also resolve Github issue #7716