fixing logging related interfaces

.gitattributes

@@ -0,0 +1 @@
+docs/images/PDF_Exatraction_Demo-VEED.gif filter=lfs diff=lfs merge=lfs -text

python-sdk/indexify/http_client.py

@@ -220,11 +220,11 @@ def create_namespace(self, namespace: str):
         self._post("namespaces", json={"name": namespace})
 
     def logs(
-        self, invocation_id: str, cg_name: str, fn_name: str, file: str
+        self, invocation_id: str, cg_name: str, fn_name: str, task_id: str, file: str
     ) -> Optional[str]:
         try:
             response = self._get(
-                f"namespaces/{self.namespace}/compute_graphs/{cg_name}/invocations/{invocation_id}/fn/{fn_name}/logs/{file}"
+                f"namespaces/{self.namespace}/compute_graphs/{cg_name}/invocations/{invocation_id}/fn/{fn_name}/tasks/{task_id}/logs/{file}"
             )
             response.raise_for_status()
             return response.content.decode("utf-8")
@@ -272,12 +272,14 @@ def invoke_graph_with_object(
                                 event.payload.invocation_id,
                                 graph,
                                 event.payload.fn_name,
+                                event.payload.task_id,
                                 "stdout",
                             )
                             stderr = self.logs(
                                 event.payload.invocation_id,
                                 graph,
                                 event.payload.fn_name,
+                                event.payload.task_id,
                                 "stderr",
                             )
                             if stdout:

python-sdk/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "indexify"
-version = "0.2.17"
+version = "0.2.18"
 description = "Python Client for Indexify"
 authors = ["Tensorlake Inc. <support@tensorlake.ai>"]
 license = "Apache 2.0"

server/src/routes/logs.rs

@@ -44,10 +44,16 @@ pub async fn download_task_logs(
                 "failed to download diagnostic payload: {}",
                 e
             ))
-        })?
-        .ok_or(IndexifyAPIError::internal_error(anyhow!(
-            "diagnostic payload not found for task"
-        )))?;
+        })?;
+
+    if payload.is_none() {
+    return Response::builder()
+        .header("Content-Type", "application/octet-stream")
+        .header("Content-Length", 0)
+        .body(Body::empty())
+        .map_err(|e| IndexifyAPIError::internal_error_str(&e.to_string()));
+    }
+    let payload = payload.unwrap();
 
     let storage_reader = state.blob_storage.get(&payload.path);
     let payload_stream = storage_reader

server/state_store/src/scanner.rs

@@ -321,9 +321,6 @@ impl StateReader {
         task_id: &str,
         file: &str,
     ) -> Result<Option<DataPayload>> {
-        let key = Task::key_prefix_for_fn(ns, cg, inv_id, cg_fn);
-        println!("{}", key);
-
         let task = self
             .get_task(ns, cg, inv_id, cg_fn, task_id)?
             .ok_or(anyhow::anyhow!("Task not found"))?;

server/ui/src/components/tables/InvocationOutputTable.tsx

@@ -201,27 +201,13 @@ const InvocationOutputTable: React.FC<InvocationOutputTableProps> = ({ indexifyS
                   <TableRow>
                     <TableCell>Compute Function</TableCell>
                     <TableCell>ID</TableCell>
-                    <TableCell>Logs</TableCell>
                   </TableRow>
                 </TableHead>
                 <TableBody>
                   {outputs.map((output, idx) => (
                     <TableRow key={idx}>
                       <TableCell>{output.compute_fn}</TableCell>
                       <TableCell>{output.id}</TableCell>
-                      <TableCell>
-                        <Button 
-                          onClick={() => viewLogs(output.compute_fn, 'stdout')}
-                          sx={{ mr: 1 }}
-                        >
-                          View stdout
-                        </Button>
-                        <Button 
-                          onClick={() => viewLogs(output.compute_fn, 'stderr')}
-                        >
-                          View stderr
-                        </Button>
-                      </TableCell>
                     </TableRow>
                   ))}
                 </TableBody>