Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodeselectors to helm #835

Merged
merged 3 commits into from
Aug 19, 2024
Merged

add nodeselectors to helm #835

merged 3 commits into from
Aug 19, 2024

Conversation

sadath-12
Copy link
Contributor

No description provided.

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Copy link
Contributor

@grampelberg grampelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want the node selectors to be the same for everything? It feels like the extractors should be distinct so that they can land on gpu nodes for example.

@jvidalg
Copy link

jvidalg commented Aug 15, 2024

Are you sure you want the node selectors to be the same for everything? It feels like the extractors should be distinct so that they can land on gpu nodes for example.

Hi @grampelberg @sadath-12 based on the values structure, it seems that each component is already independently customizable. Adding nodeSelector: {} to the values file could make this clearer, for example:

api:
  enabled: true
  nodeSelector: {}

coordinator:
  enabled: true
  nodeSelector: {}

extractors:
  - name: extractor1
    nodeSelector: {}

  - name: extractor2
    nodeSelector: {}

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@sadath-12
Copy link
Contributor Author

Are you sure you want the node selectors to be the same for everything? It feels like the extractors should be distinct so that they can land on gpu nodes for example.

Hi @grampelberg @sadath-12 based on the values structure, it seems that each component is already independently customizable. Adding nodeSelector: {} to the values file could make this clearer, for example:

api:
  enabled: true
  nodeSelector: {}

coordinator:
  enabled: true
  nodeSelector: {}

extractors:
  - name: extractor1
    nodeSelector: {}

  - name: extractor2
    nodeSelector: {}

ya but I wanted in values.yaml itself

@diptanu diptanu merged commit b690763 into tensorlakeai:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants