Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(sdk): faciliate using namespaces with remote graphs #978

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

seriousben
Copy link
Contributor

@seriousben seriousben commented Oct 24, 2024

This PR removes the need for any workaround to use namespaces by supporting a IndexifyClient in the RemoteGraph class methods.

Deploying, Running, Outputting will reuse the same client which can be configured with a namespace.

Some docstring formatting was also done.

Testing

  • Manual testing passing client

      client = IndexifyClient(namespace="object_detection")
      g = RemoteGraph.deploy(g, client=client)
  • Manual testing backward compatible

     g = RemoteGraph.deploy(g)
  • Run make fmt.
    Not needed

  • pip install -e ., start server and executor, cd to python-sdk/tests, python test_graph_behaviours.py.

     .
     ----------------------------------------------------------------------
     Ran 7 tests in 1.578s
     
     OK
    

@diptanu
Copy link
Collaborator

diptanu commented Oct 24, 2024

Looks good

@seriousben seriousben force-pushed the seriousben/support-client-in-remote-graphs branch from f931c88 to 1eb6fb9 Compare October 24, 2024 18:33
@diptanu diptanu merged commit 5d1e41c into main Oct 24, 2024
1 check passed
@diptanu diptanu deleted the seriousben/support-client-in-remote-graphs branch October 24, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants