Pyluwen: Add "version" to pyproject.toml #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maturin made a change to come inline more specifically with pyproject.toml spec, unfortunately it's not a "backwards compatible" change and was done with little fanfare or warning, and immediately caused breakage outside distro's more plodding versions. Maturin Issue: PyO3/maturin#2390 pyproject.toml spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic change in Maturin committed here: PyO3/maturin#2391 This commit superceeds the luwen PR here: tenstorrent#11 as that sets an explicit version, and we don't want that as it adds more sources of truth on the version (seriously there should be 1, and only 1). Reported-by: Dongjin Na <dongjin.na@moreh.io> Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
warthog9
force-pushed
the
jhawley/maturin-version-fix
branch
from
6f622ea to
754b8b6
Compare
warthog9
added a commit
to tenstorrent/tt-tools-common
that referenced
this pull request
Dec 30, 2024
Luwen needed an update to deal with Maturin, this should sort it downstream as well. tenstorrent/luwen#12 Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
warthog9
added a commit
to tenstorrent/tt-smi
that referenced
this pull request
Dec 30, 2024
Maturin made some updates / changes, that required the luwen version to bump. So bumping the luwen version tenstorrent/luwen#12 if you are curious Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maturin made a change to come inline more specifically with pyproject.toml spec, unfortunately it's not a "backwards compatible" change and was done with little fanfare or warning, and immediately caused breakage outside distro's more plodding versions.
Maturin Issue: PyO3/maturin#2390
pyproject.toml spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic
change in Maturin committed here:
PyO3/maturin#2391
This commit superceeds the luwen PR here:
#11
as that sets an explicit version, and we don't want that as it adds more sources of truth on the version (seriously there should be 1, and only 1).