Add no-skips argument in unique ops config generation subprocess run method in model analysis #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekaranpradeep
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
…method in model analysis
chandrasekaranpradeep
force-pushed
the
pchandrasekaran/add_no_skip_option
branch
from
cb05b6b to
40361b7
Compare
nvukobratTT
approved these changes
Jan 17, 2025
|
||||||||||||||
|
||||||||||||||
ashokkumarkannan1
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we skipped some of the model variants due to CI limitation and those model variants will also be skipped in the model analysis pipeline. To avoid skipping the model variants in model analysis, added
--no-skipsargument in the subprocess run method in extraction and generation of unique ops config test function(i.egenerate_and_export_unique_ops_tests in scripts/model_analysis/unique_ops_utils.py)