[Op] Further support for reciprocal #112 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolubovicTT
approved these changes
Sep 2, 2024
Uncovered new blocker related to the invalid setup of reciprocal on MLIR side. More precisely, it requires 2 attributes instead of 1 due to limitation of being defined as elementwise binary op on TTIR to TTNN op conversion. Potential root cause (enforces eltwise binary checks): ``` third_party/tt-mlir/lib/Conversion/TTIRToTTNN/TTIRToTTNN.cpp::populateTTIRToTTNNPatterns ```
nvukobratTT
force-pushed
the
nvukobrat/reciprocal
branch
from
c86a1f6 to
e2a538f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered new blocker related to the invalid setup of reciprocal on MLIR side. More precisely, it requires 2 attributes instead of 1 due to limitation of being defined as elementwise binary op on TTIR to TTNN op conversion.
Potential root cause (enforces eltwise binary checks):