Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] PassThroughScheduling is visibile in profiler #14366

Closed
dmakoviichuk-tt opened this issue Oct 28, 2024 · 0 comments
Closed

[Bug Report] PassThroughScheduling is visibile in profiler #14366

dmakoviichuk-tt opened this issue Oct 28, 2024 · 0 comments
Assignees
@sminakov-tt
Labels
perf for issues tracking performance problems/improvements TT-train

Comments

@dmakoviichuk-tt
Copy link
Contributor

Describe the bug
It calls for https://man7.org/linux/man-pages/man3/pthread_self.3.html each time we enter the function.
Call itself is not that slow but we do it million of times.
To Reproduce
Steps to reproduce the behavior:
Run any op.
Expected behavior
Buffer->address() call should be as fast as possible
Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2024-10-27 at 1 10 10 PM
@dmakoviichuk-tt dmakoviichuk-tt added the bug Something isn't working label Oct 28, 2024
sminakov-tt added a commit that referenced this issue Oct 28, 2024
@sminakov-tt
#14366: Allow creating pre-allocated buffer with an address. Minor pe…
6555b54 
…rformance improvements
@sminakov-tt sminakov-tt mentioned this issue Oct 28, 2024
Merged
5 tasks
sminakov-tt added a commit that referenced this issue Oct 29, 2024
@sminakov-tt
#14366: Allow creating pre-allocated buffer with an address. Minor pe…
8cc5fa5 
…rformance improvements
sminakov-tt added a commit that referenced this issue Oct 29, 2024
@sminakov-tt
#14366: Allow creating pre-allocated buffer with an address. Minor pe…
d4b7fc2 
…rf improvements (#14394)

* #14366: Allow creating pre-allocated buffer with an address. Minor performance improvements

* #0: Cleanup

* #0: Updated methods documentation

* #0: Handle allocation failure

* #0: Scheduling fix
@dmakoviichuk-tt dmakoviichuk-tt added perf for issues tracking performance problems/improvements TT-train and removed bug Something isn't working labels Oct 30, 2024
ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this issue Nov 12, 2024
@sminakov-tt
tenstorrent#14366: Allow creating pre-allocated buffer with an addres…
c56c3ab 
…s. Minor perf improvements (tenstorrent#14394)

* tenstorrent#14366: Allow creating pre-allocated buffer with an address. Minor performance improvements

* #0: Cleanup

* #0: Updated methods documentation

* #0: Handle allocation failure

* #0: Scheduling fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sminakov-tt sminakov-tt

Labels
perf for issues tracking performance problems/improvements TT-train
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ayerofieiev-tt @dmakoviichuk-tt @sminakov-tt