Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ViT and reenable tests for CI #7527

Open
TT-BrianLiu opened this issue Apr 16, 2024 · 0 comments
Open

Review ViT and reenable tests for CI #7527

TT-BrianLiu opened this issue Apr 16, 2024 · 0 comments
Assignees
@mbahnasTT
Labels
feature P1

Comments

@TT-BrianLiu
Copy link
Contributor

TT-BrianLiu commented Apr 16, 2024 •
edited
Loading

Review ViT model and test code.

For tests, all of them use default 0.9999 PCC for checking and they all fail. There's a lot of tests from this PR: #7503

Needs review to see which to enable. If we do, we need to lower the PCC requirement.
TT-BrianLiu pushed a commit that referenced this issue Apr 16, 2024
@mbahnasTT @TT-BrianLiu
#6712: Add ViT model code + tests
e095bd9 
- Update create_sharded_device_tensor to respect non-4D shapes
- Disable all tests (#7527) except sharded ViT
TT-BrianLiu pushed a commit that referenced this issue Apr 16, 2024
@mbahnasTT @TT-BrianLiu
#6712: Add ViT model code + tests
7213671 
- Update create_sharded_device_tensor to respect non-4D shapes
- Disable all tests (#7527) except sharded ViT
TT-BrianLiu pushed a commit that referenced this issue Apr 17, 2024
@mbahnasTT @TT-BrianLiu
#6712: Add ViT model code + tests
bb857df 
- Update create_sharded_device_tensor to respect non-4D shapes
- Disable all tests (#7527) except sharded ViT
@TT-BrianLiu TT-BrianLiu changed the title Review ViT tests and reenable for CI Review Vi and reenable teats for CI Apr 17, 2024
@jliangTT jliangTT changed the title Review Vi and reenable teats for CI Review ViT and reenable teats for CI Apr 17, 2024
@jliangTT jliangTT changed the title Review ViT and reenable teats for CI Review ViT and reenable tests for CI Apr 17, 2024
@jliangTT jliangTT added the bug Something isn't working label Apr 17, 2024
TT-BrianLiu added a commit that referenced this issue Apr 18, 2024
@TT-BrianLiu
#7527: Disable old ViT tests
defd64d
TT-BrianLiu added a commit that referenced this issue Apr 18, 2024
@TT-BrianLiu
#7527: Disable old ViT tests
ae149f4
dimitri-tenstorrent pushed a commit that referenced this issue Apr 19, 2024
@mbahnasTT @dimitri-tenstorrent
#6712: Add ViT model code + tests
3acf736 
- Update create_sharded_device_tensor to respect non-4D shapes
- Disable all tests (#7527) except sharded ViT
dimitri-tenstorrent pushed a commit that referenced this issue Apr 19, 2024
@TT-BrianLiu @dimitri-tenstorrent
#7527: Disable old ViT tests
60cf250
@mbahnasTT mbahnasTT self-assigned this May 1, 2024
@mbahnasTT mbahnasTT added feature and removed bug Something isn't working labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbahnasTT mbahnasTT

Labels
feature P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TT-BrianLiu @mbahnasTT @jliangTT