#7560: Fix FD noc api to set multicast_path_reserve when mcasting #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgkeller
approved these changes
Jul 30, 2024
tt-asaigal
approved these changes
Jul 31, 2024
… to switch to using NOC_DISPATCH_MULTICAST_WRITE_VC for all dispatch mcasts Remove some minor riscv overhead since we don't need to create full noc addrs if we're not reprogramming the noc coords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#7560
Problem description
Stable diffusion was still seeing hangs after di/dt fixes. Was narrowed down to a commit that changed the FD eth cores used for prefetch/dispatch, which affected timing. The real latent bug was that multicast_path_reserve was not being set with the new noc apis used in some FD commands, leading to potential NOC deadlock.
What's changed
Always set multicast_path_reserve for now for all mcast transactions with the new apis.
Checklist