#7560: Re-enable Stable Diffusion tests in CI #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmalTT
force-pushed
the
esmal/enable-sd-tests
branch
from
4548009 to
fb12634
Compare
esmalTT
force-pushed
the
esmal/enable-sd-tests
branch
from
fb12634 to
4e3eb4c
Compare
esmalTT
force-pushed
the
esmal/enable-sd-tests
branch
from
4e3eb4c to
34986f7
Compare
esmalTT
requested review from
tt-rkim,
vtangTT,
ttmchiou and
TT-billteng
as code owners
tt-rkim
reviewed
Aug 8, 2024
| @@ -10,7 +10,7 @@ fail=0 | |||
|
|
|||
| echo "Running unstable nightly tests for WH B0 only" | |||
|
|
|||
| SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest -n auto tests/ttnn/integration_tests/stable_diffusion ; fail+=$? | |||
| env SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml pytest -n auto tests/ttnn/integration_tests/stable_diffusion ; fail+=$? | |||
|
how's a run of this looking like for nightly FD? |
@tt-rkim These two seem good: |
tt-rkim
approved these changes
Aug 8, 2024
|
RUN ITTTTT Do we need to update SD codeowners? |
esmalTT
force-pushed
the
esmal/enable-sd-tests
branch
2 times, most recently
from
ee36d9c to
0978a39
Compare
@tt-rkim Good call. I updated it here in a separate commit. Added @mywoodstock as an owner as well since I think he's the most familiar with SD at the moment - let me know if you think someone else is better suited. |
esmalTT
force-pushed
the
esmal/enable-sd-tests
branch
from
0978a39 to
6797bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#7560
Summary
It seems like we can re-enable the SD tests with
SLOW_MATMULSenabled, as I have not seen any hangs or failures after 3 pipeline runs in this configuration.Once merged, I will monitor the pipeline for failures.
Checklist