#14448: Update examples of binary ops #14468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcw-anasuya
requested review from
umadevimcw,
VirdhatchaniKN,
Aswinmcw,
KalaivaniMCW and
mouliraj-mcw
KalaivaniMCW
approved these changes
Oct 30, 2024
VirdhatchaniKN
approved these changes
Oct 30, 2024
mcw-anasuya
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
umadevimcw
approved these changes
Oct 30, 2024
| >>> tensor1 = ttnn.to_device(ttnn.from_torch(torch.tensor((1, 2), dtype=torch.bfloat16)), device) | ||
| >>> tensor2 = ttnn.to_device(ttnn.from_torch(torch.tensor((0, 1), dtype=torch.bfloat16)), device) | ||
| >>> tensor1 = ttnn.to_device(ttnn.from_torch(torch.tensor(([[1, 2], [3, 4]]), dtype=torch.bfloat16)), device) | ||
| >>> tensor2 = ttnn.to_device(ttnn.from_torch(torch.tensor(([[1, 2], [3, 4]]), dtype=torch.bfloat16)), device) | ||
| >>> output = {1}(tensor1, tensor2) |
There was a problem hiding this comment.
What was the issue ? Is it zero or the format how it passed?
There was a problem hiding this comment.
The format that we passed.
torch.tensor((1, 2), dtype=torch.bfloat16) creates a tensor of rank 1 with elements [1 2].
According to the documentation, most of the ops support ranks of 2, 3, 4. That's why we passed the input as
[1 2
3 4]
eyonland
approved these changes
Oct 30, 2024
mcw-anasuya
force-pushed
the
anasuya/update_binary_example
branch
from
345d5ee to
f8de925
Compare
mcw-anasuya
force-pushed
the
anasuya/update_binary_example
branch
from
f8de925 to
a1eb0fa
Compare
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this pull request
Nov 12, 2024
tenstorrent#14448: Update examples, wordings of binary ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14448
Problem description
Shape in examples inconsistent with op.
Currently we support device operations for ranks > 2 as per doc. The example in the doc creates a 1D tensor.
What's changed
Checklist