Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize_shape refactoring #14565

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Conversation

amalbasaTT
Copy link
Contributor

@amalbasaTT amalbasaTT commented Nov 1, 2024

Problem description

Refactoring all sweeps who use input_shape mutilation (except for row_major sanitize).

What's changed

  1. Added sanitize_shape function in sweep_framework/utils.py
  2. Removed sanitize_topk_shape function in sweep_framework/utils.py
  3. Refactored split_query_key_value_and_split_heads, split_query_key_value_and_split_heads_kv_input accordingly and included golden functions
  4. Refactored topk accordingly
  5. Also reduced number of argmax sweep parameters

@amalbasaTT amalbasaTT force-pushed the amalbasaTT/sanitize_shape-refactoring branch from c53b24e to 98e9c99 Compare November 4, 2024 13:56
@amalbasaTT amalbasaTT force-pushed the amalbasaTT/sanitize_shape-refactoring branch from e8cb0d1 to fa8eb3a Compare November 4, 2024 15:02
@amalbasaTT amalbasaTT merged commit 6512ac5 into main Nov 4, 2024
8 checks passed
@amalbasaTT amalbasaTT deleted the amalbasaTT/sanitize_shape-refactoring branch November 4, 2024 15:05
ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this pull request Nov 12, 2024
* tenstorrent#11512: sanitize_shape refactoring

* tenstorrent#11512: remove sanitize_topk_shape

* tenstorrent#11512: Remove print functions from sanitize_shapes

* tenstorrent#11512: Modify sanitize_shape_rm function

* tenstorrent#11512: Reduce argmax sweep number of parameters

* tenstorrent#11512: Modify invalidate_function inside split_query_key_valu_and_split_heads..py sweep

* tenstorrent#11512: Modify santizie_shape function inside utils when method is split_query_key_value_and_split_heads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants