Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13685: Update backward embedding document #14666

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

mcw-anasuya
Copy link
Contributor

@mcw-anasuya mcw-anasuya commented Nov 4, 2024

Ticket

#13685

Problem description

  • ttnn.embedding_bw doesn't support output and input gradient tensors having different dtypes.
  • ttnn.embedding_bw is not an eltwise op. So, moving corresponding tests outside eltwise folder.

What's changed

  • Updated document to add a note mentioning input and output gradients must have the same datatype.
  • Moved sweep test from tests/sweep_framework/sweeps/eltwise/binary_backward/embedding_bw/embedding_bw.py to tests/sweep_framework/sweeps/embedding_bw/embedding_bw.py
  • Move unit test from from tests/ttnn/unit_tests/operations/eltwise/backward/test_backward_embedding.py to tests/ttnn/unit_tests/operations/test_backward_embedding.py

Updated doc

Screenshot 2024-11-04 at 17 49 31

Checklist

@mcw-anasuya mcw-anasuya force-pushed the anasuya/embedding_bw_doc branch from 7caffc9 to 6852fe0 Compare November 4, 2024 12:20
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyonland eyonland requested a review from ntarafdar November 6, 2024 05:34
@mcw-anasuya mcw-anasuya force-pushed the anasuya/embedding_bw_doc branch from ef9c84d to b99c195 Compare November 8, 2024 15:47
@mcw-anasuya mcw-anasuya force-pushed the anasuya/embedding_bw_doc branch from b99c195 to 030ff75 Compare November 11, 2024 06:36
@mcw-anasuya mcw-anasuya merged commit fec3ebc into main Nov 11, 2024
118 checks passed
@mcw-anasuya mcw-anasuya deleted the anasuya/embedding_bw_doc branch November 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants