-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#13685: Update backward embedding document #14666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcw-anasuya
force-pushed
the
anasuya/embedding_bw_doc
branch
from
November 4, 2024 12:20
7caffc9
to
6852fe0
Compare
KalaivaniMCW
approved these changes
Nov 4, 2024
mcw-anasuya
force-pushed
the
anasuya/embedding_bw_doc
branch
from
November 4, 2024 16:38
6852fe0
to
bf88d4e
Compare
mcw-anasuya
requested review from
umadevimcw,
VirdhatchaniKN,
Aswinmcw,
mouliraj-mcw and
KalaivaniMCW
November 4, 2024 16:57
umadevimcw
approved these changes
Nov 4, 2024
Aswinmcw
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VirdhatchaniKN
approved these changes
Nov 5, 2024
mcw-anasuya
requested review from
patrickroberts,
yan-zaretskiy,
eyonland,
TT-BrianLiu,
xanderchin,
jdesousa-TT and
sjameelTT
as code owners
November 5, 2024 05:03
mcw-anasuya
force-pushed
the
anasuya/embedding_bw_doc
branch
2 times, most recently
from
November 5, 2024 05:59
d31b214
to
ef9c84d
Compare
mcw-anasuya
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
razorback3 and
dongjin-na
as code owners
November 5, 2024 05:59
KalaivaniMCW
approved these changes
Nov 5, 2024
eyonland
approved these changes
Nov 5, 2024
ntarafdar
approved these changes
Nov 6, 2024
yan-zaretskiy
approved these changes
Nov 6, 2024
jdesousa-TT
approved these changes
Nov 6, 2024
cfjchu
approved these changes
Nov 6, 2024
mcw-anasuya
force-pushed
the
anasuya/embedding_bw_doc
branch
from
November 8, 2024 15:47
ef9c84d
to
b99c195
Compare
mcw-anasuya
force-pushed
the
anasuya/embedding_bw_doc
branch
from
November 11, 2024 06:36
b99c195
to
030ff75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#13685
Problem description
What's changed
tests/sweep_framework/sweeps/eltwise/binary_backward/embedding_bw/embedding_bw.py
totests/sweep_framework/sweeps/embedding_bw/embedding_bw.py
tests/ttnn/unit_tests/operations/eltwise/backward/test_backward_embedding.py
totests/ttnn/unit_tests/operations/test_backward_embedding.py
Updated doc
Checklist