UMD bump: Remove usage of create-ethernet-map #14718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
1 task
abhullar-tt
reviewed
Nov 5, 2024
Yes, this is the way we plan on doing it going forward for each change. |
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Nov 6, 2024
Related to #99 This change will simplify our build system changes by a lot. No additional artefacts needed to be shipped with libdevice, and no thinking about relative/absolute path once the lib is built. @TTDRosen provided this library. Changes: - Add lib to git, add it to build system. - Remove CEM binary from git - Add cluster yaml creation to tt_ClusterDescriptor - Use this interface in tests, remove deprecated GetClusterDescYAML The following PR will remove cluster yaml altogether. Both from tt_ClusterDescriptor interface and from tt_SiliconDevice. Didn't want to overwhelm this PR. This change requires client changes. Breaks existing references to create-ethernet-map binary - [x] tt_metal corresponding PR: tenstorrent/tt-metal#14718 - tt_debuda has its own CEM so it will continue to build without any changes.
abhullar-tt
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #13948
What's changed
Related UMD PR: tenstorrent/tt-umd#245
Remove usage of create-ethernet-map. This is now a static lib in UMD, and UMD now offers an interface to get cluster yaml. In following PRs even this will be removed, and won't be visible to clients at all.
The change points to a non-main branch for purposes of having approval before completing UMD PR, but this PR will be switched to point to UMD main before checked in.
Checklist