Yieldthought/lt persist state #14891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yieldthought
requested review from
cglagovichTT,
mtairum and
uaydonat
as code owners
cglagovichTT
approved these changes
Nov 8, 2024
| # Restore saved attributes | ||
| entry.status = ( | ||
| "Cancelled" | ||
| if entry_data["status"] |
There was a problem hiding this comment.
Should status be "cancelled" if the status is in this list?
There was a problem hiding this comment.
Yes - this is to account for cases in which lt was terminated without its usual shutdown (e.g. ird timeout, connection lost etc). Those processes are gone and are not coming back.
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this pull request
Nov 12, 2024
* #0: Tie name of each log to a slot index * #0: Detach log id's from visible index as this changes on deletion * #0: remove logs when deleted from list * #0: Persist lt status in logs/status.json * #0: always reset on error code unless cancelled * #0: Add X to clear all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Problem description
Using lt for multiple runs of the same input would share log files, exiting lt by mistake would lose output and state
What's changed
Unique log index for each run, log files removed when they are removed from lt, lt state persisted between runs
Checklist