Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14782: Automating supported params table for unary backward ops #14894

Merged
merged 2 commits into from
Nov 11, 2024
Merged

#14782: Automating supported params table for unary backward ops #14894

merged 2 commits into from
Nov 11, 2024

Conversation

mcw-anasuya
Copy link
Contributor

@mcw-anasuya mcw-anasuya commented Nov 8, 2024 •
edited
Loading

Ticket

#14782

Problem description

The table format needs to be updated in unary backward pybind to avoid duplicating it for each op that is added.

What's changed

  • Updated supported parameters table format
  • Reworded some descriptions
  • Added clip_bw to rst file
  • Move some binary backward ops from unary backward doc list.

Checklist

@mcw-anasuya mcw-anasuya marked this pull request as ready for review November 8, 2024 14:46
Aswinmcw
Aswinmcw approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcw-anasuya mcw-anasuya force-pushed the anasuya/unary_bw_table branch from 7eaeb33 to 47fea7e Compare November 8, 2024 14:58
@mcw-anasuya mcw-anasuya force-pushed the anasuya/unary_bw_table branch 2 times, most recently from 36c7866 to 953291d Compare November 11, 2024 08:25
@mcw-anasuya mcw-anasuya force-pushed the anasuya/unary_bw_table branch from 953291d to 7f20e28 Compare November 11, 2024 09:59
@mcw-anasuya mcw-anasuya merged commit f42fc28 into main Nov 11, 2024
9 checks passed
@mcw-anasuya mcw-anasuya deleted the anasuya/unary_bw_table branch November 11, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalaivaniMCW KalaivaniMCW KalaivaniMCW approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@VirdhatchaniKN VirdhatchaniKN VirdhatchaniKN approved these changes

@eyonland eyonland eyonland approved these changes

@umadevimcw umadevimcw umadevimcw approved these changes

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcw-anasuya @umadevimcw @eyonland @VirdhatchaniKN @Aswinmcw @KalaivaniMCW