Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer support for eltwise ops #14953

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Add integer support for eltwise ops #14953

merged 1 commit into from
Nov 17, 2024

Conversation

mouliraj-mcw
Copy link
Contributor

@mouliraj-mcw mouliraj-mcw commented Nov 12, 2024

Ticket

Link to Github Issue #13374

What's changed

  • Updated the comparison ops to return datatype as integer.

Ops Added Int Support:

  • ELEMWISE_UNARY_EQ
  • ELEMWISE_UNARY_GE
  • ELEMWISE_UNARY_GT
  • ELEMWISE_UNARY_LE
  • ELEMWISE_UNARY_LT
  • ELEMWISE_UNARY_NE
  • ELEMWISE_BINARY_GE
  • ELEMWISE_BINARY_GT
  • ELEMWISE_BINARY_EQ
  • ELEMWISE_BINARY_LE
  • ELEMWISE_BINARY_LOGICALAND
  • ELEMWISE_BINARY_LOGICALOR
  • ELEMWISE_BINARY_LOGICALXOR
  • ELEMWISE_BINARY_LT
  • ELEMWISE_BINARY_NE

Checklist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test cases passing optional output tensor for both variants here

@KalaivaniMCW
Copy link
Contributor

@mouliraj-mcw Please list the ops that are being handled in this PR in the description.

Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aswinmcw Aswinmcw force-pushed the mouliraj/int_support branch 2 times, most recently from bd767b0 to 9993c25 Compare November 14, 2024 10:49
@mouliraj-mcw mouliraj-mcw merged commit 7a99cc8 into main Nov 17, 2024
9 checks passed
@mouliraj-mcw mouliraj-mcw deleted the mouliraj/int_support branch November 17, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants