#14982: Update threshold logic #15362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirdhatchaniKN
force-pushed
the
virdhatchani/unary_example_3
branch
3 times, most recently
from
d58c433 to
b40ffdf
Compare
VirdhatchaniKN
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
VirdhatchaniKN
force-pushed
the
virdhatchani/unary_example_3
branch
from
b40ffdf to
d50960f
Compare
mouliraj-mcw
approved these changes
Nov 22, 2024
| module, | ||
| ttnn::threshold, | ||
| "threshold", "Threshold value", | ||
| "value", "Value value", | ||
| "value", "Replacing value", |
There was a problem hiding this comment.
"value to replace with"
There was a problem hiding this comment.
That would look same as PyTorch, and hence i thought this would work
KalaivaniMCW
approved these changes
Nov 22, 2024
eyonland
approved these changes
Nov 22, 2024
umadevimcw
approved these changes
Nov 23, 2024
VirdhatchaniKN
force-pushed
the
virdhatchani/unary_example_3
branch
3 times, most recently
from
862cb28 to
15bfa83
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/unary_example_3
branch
from
15bfa83 to
c1c6982
Compare
spoojaryTT
pushed a commit
that referenced
this pull request
Nov 25, 2024
### Ticket #14982 ### Problem description Provide context for the problem. ### What's changed - Updated threshold logic to handle cases when input_tensor=threshold value - Updated with supported data type and layout Tests : - `pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_eltwise_threshold.py` : <img width="1101" alt="Screenshot 2024-11-22 at 6 09 03 PM" src="https://github.com/user-attachments/assets/80b5820f-8e4d-4a8b-9914-d3df21f72f90"> - `pytest tests/ttnn/unit_tests/operations/eltwise/test_activation.py::test_threshold` : <img width="1087" alt="Screenshot 2024-11-22 at 6 09 39 PM" src="https://github.com/user-attachments/assets/61f30c51-5d78-49d2-af08-e7c764a330a0"> - `pytest tests/ttnn/unit_tests/operations/eltwise/test_composite.py::test_unary_composite_threshold_ttnn` : <img width="1088" alt="Screenshot 2024-11-22 at 6 10 21 PM" src="https://github.com/user-attachments/assets/a2ca063e-65fb-4a4e-a9cc-6348eb3c95c0"> - `python tests/ttnn/sweep_tests/run_sweeps.py --include threshold.py` - passed - `pytest tests/ttnn/unit_tests/operations/eltwise/test_composite.py::test_threshold_example` : <img width="1092" alt="Screenshot 2024-11-22 at 6 11 40 PM" src="https://github.com/user-attachments/assets/56eafb45-8011-440c-8958-f212869b0634"> ### Checklist - [ ] Post commit CI passes ### Doc screenshot <img width="963" alt="Screenshot 2024-11-22 at 11 06 48 PM" src="https://github.com/user-attachments/assets/1be96ac7-dc1b-434a-ad1d-ebe95edd7b51">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14982
Problem description
Provide context for the problem.
What's changed
Tests :
pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_eltwise_threshold.py:pytest tests/ttnn/unit_tests/operations/eltwise/test_activation.py::test_threshold:pytest tests/ttnn/unit_tests/operations/eltwise/test_composite.py::test_unary_composite_threshold_ttnn:python tests/ttnn/sweep_tests/run_sweeps.py --include threshold.py- passedpytest tests/ttnn/unit_tests/operations/eltwise/test_composite.py::test_threshold_example:Checklist
Doc screenshot