#15061: Extended {to,from}_vector to support tilized layout, bf4/8 formats #16105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
previously requested changes
Dec 17, 2024
omilyutin-tt
force-pushed
the
omilyutin/bf
branch
from
442dd88 to
d21d2c4
Compare
omilyutin-tt
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-asaigal
approved these changes
Dec 20, 2024
ayerofieiev-tt
approved these changes
Dec 23, 2024
omilyutin-tt
force-pushed
the
omilyutin/bf
branch
from
115db1e to
dcb4e6d
Compare
|
@cfjchu as per the discussion offline, discarding the requested changes to unblock the PR - the feedback will be addressed in follow ups to speed up tilization on-device |
arikTT
pushed a commit
that referenced
this pull request
Dec 27, 2024
…rmats (#16105) ### Ticket #15061 ### Problem description `to_vector` / `from_vector` don't support some of the special cases, which prevents a more widespread adoption (distributing tensors across mesh of devices in particular). ### What's changed * Support tilized layouts. * Support bf4 / bf8 data types with auto-padding. * Extended `chunk` / `concat` support for the added types. ### Next steps * Optimize certain operations on-device, such as tilization, whenever possible. * Perform auto-padding in tilized layouts / when using sharding. * Switching pytensor logic to using `from_vector` API. ### Checklist - [X] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12422597810) - [X] New/Existing tests provide coverage for changes --------- Co-authored-by: Oleg Milyutin <omilyutin-tt@tenstorrent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#15061
Problem description
to_vector/from_vectordon't support some of the special cases, which prevents a more widespread adoption (distributing tensors across mesh of devices in particular).What's changed
chunk/concatsupport for the added types.Next steps
from_vectorAPI.Checklist