Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12662: add keepdim fixes to reduce #16163

Merged
merged 4 commits into from
Dec 20, 2024
Merged

#12662: add keepdim fixes to reduce #16163

merged 4 commits into from
Dec 20, 2024

Conversation

bbradelTT
Copy link
Contributor

@bbradelTT bbradelTT commented Dec 19, 2024 •
edited
Loading

Ticket

Link to Github Issue #12662 #14898 #13361 #12170

Problem description

  • padding caused issues for max
  • keepdim=False errored out

What's changed

  • remove the erroring out of keepdim=False and adjust code to handle keepdim=False properly
  • adding padding within min/max to ensure that it's set up properly has been pushed back to a future PR

Checklist

@LPanosTT LPanosTT mentioned this pull request Dec 19, 2024
Merged
@bbradelTT bbradelTT changed the title #12662: add keepdim and max fixes to reduce #12662: add keepdim fixes to reduce Dec 20, 2024
sjameelTT
sjameelTT approved these changes Dec 20, 2024
View reviewed changes
ttnn/cpp/ttnn/operations/reduction/generic/generic_reductions.cpp
output, -2, /*keepdim=*/true, memory_config, compute_kernel_config, scalar, /*reshape=*/true);
output = ttnn::transpose(output, 0, -2, memory_config);
if (reshape) {
output = ttnn::reshape(output, ttnn::Shape{output_shape});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple shape?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR. For now I'll keep as Shape to be in line with existing code.

asandhupatlaTT
asandhupatlaTT approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@asandhupatlaTT asandhupatlaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbradelTT bbradelTT mentioned this pull request Nov 8, 2024
Closed
@bbradelTT bbradelTT merged commit ec1869e into main Dec 20, 2024
359 checks passed
@bbradelTT bbradelTT deleted the bbradel-12662_max branch December 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@sjameelTT sjameelTT sjameelTT approved these changes

@asandhupatlaTT asandhupatlaTT asandhupatlaTT approved these changes

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbradelTT @sjameelTT @ayerofieiev-tt @asandhupatlaTT