#15450: Remove default values from circular buffer parameters in LLK compute APIs: Test Kernels #16613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atatuzunerTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
approved these changes
Jan 14, 2025
| @@ -44,7 +44,7 @@ void MAIN { | |||
| constexpr uint32_t Wt = get_compile_time_arg_val(1); | |||
| constexpr uint32_t NC = get_compile_time_arg_val(2); | |||
| constexpr bool at_start = get_compile_time_arg_val(3); | |||
| dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2); | |||
| dummy_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2, tt::CBIndex::c_16); | |||
| #ifndef SHORT_INIT | |||
| reduce_init<at_start>(tt::CBIndex::c_0, tt::CBIndex::c_2); | |||
There was a problem hiding this comment.
Will output cb to reduce_init be added in a separate pr addressing reduce_init default arg removal?
There was a problem hiding this comment.
Yes, here is the PR for that
amahmudTT
approved these changes
Jan 14, 2025
…. Call chains updated accordingly.
atatuzunerTT
force-pushed
the
atuzuner/remove_default_values_test_kernels
branch
from
7d471be to
3798f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Default values for circular buffer arguments in the LLK compute API can cause errors. Forgetting to set these arguments explicitly may lead to errors due to wrong cb usage. This PR is specific to the changes in the internal test kernel APIs:
What's changed
Default values for the circular buffer parameters have been removed from functions within these files. The call chains invoking these functions have been updated to contain explicit arguments for these parameters.
Checklist