Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Fix failing TG regression tests #16776

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tt_metal/distributed/coordinate_translation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ MeshShape get_system_mesh_shape(size_t system_num_devices) {

std::pair<CoordinateTranslationMap, MeshShape> get_system_mesh_coordinate_translation_map() {
static const auto* cached_translation_map = new std::pair<CoordinateTranslationMap, MeshShape>([] {
auto system_num_devices = tt::Cluster::instance().number_of_devices();
auto system_num_devices = tt::Cluster::instance().number_of_user_devices();

std::string galaxy_mesh_descriptor = "TG.json";
if (tt::Cluster::instance().number_of_pci_devices() == system_num_devices) {
Expand Down
6 changes: 4 additions & 2 deletions tt_metal/distributed/system_mesh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,11 @@ std::vector<chip_id_t> SystemMesh::Impl::get_mapped_physical_device_ids(const Me
// First check if total size fits
TT_FATAL(
requested_num_rows * requested_num_cols <= system_mesh_rows * system_mesh_cols,
"Requested submesh is too big: {}x{}",
"Requested submesh is too big: {}x{}, SystemMesh shape: {}x{}",
requested_num_rows,
requested_num_cols);
requested_num_cols,
system_mesh_rows,
system_mesh_cols);

bool is_single_row_or_column = requested_num_rows == 1 or requested_num_cols == 1;
if (is_single_row_or_column) {
Expand Down
Loading