Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Datagram Sockets to Fabric #16951

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Datagram Sockets to Fabric #16951

wants to merge 3 commits into from

Conversation

aagarwalTT
Copy link
Contributor

@aagarwalTT aagarwalTT commented Jan 21, 2025 •
edited
Loading

Ticket

Link to Github Issue

Problem description

Fabric implementation currently supports low level writes and atomic inc APIs.

What's changed

Adds Datagram Sockets feature to fabric. Introduces a gatekeeper kernel for context management with corresponding updates to existing tests.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

ubcheema and others added 3 commits January 21, 2025 15:56
@ubcheema @aagarwalTT
Add gatekeeper to manage sockets.
318ddab 
    Add apis to Open/Connect datagram sockets.
    Add Socket sanity test.
@aagarwalTT
Rebase and fix tests
2e68154
@aagarwalTT
Update namespace
0daeb14
@aagarwalTT aagarwalTT mentioned this pull request Jan 22, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubcheema ubcheema ubcheema approved these changes

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT will be requested when the pull request is marked ready for review aliuTT is a code owner

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt will be requested when the pull request is marked ready for review abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller will be requested when the pull request is marked ready for review pgkeller is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho will be requested when the pull request is marked ready for review tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma will be requested when the pull request is marked ready for review tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal will be requested when the pull request is marked ready for review tt-asaigal is a code owner

@eelkozahTT eelkozahTT Awaiting requested review from eelkozahTT eelkozahTT will be requested when the pull request is marked ready for review eelkozahTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aagarwalTT @ubcheema