Revert "Change ttnn->emitc transform to use dialect conversion API (#148

)" (#181) This reverts commit 4da2db8.
tenstorrent · Jul 17, 2024 · f660b92 · f660b92
1 parent 732d081
commit f660b92
Show file tree

Hide file tree

Showing 19 changed files with 180 additions and 353 deletions.
diff --git a/docs/src/adding-an-op.md b/docs/src/adding-an-op.md
@@ -140,8 +140,8 @@ TTIRToTTNNBinaryOpRewriter<ttir::MatmulOp, MatmulOp>
 ```
 
 We also need to add this op to the C++ emitter,
-`lib/Conversion/TTNNToEmitC/TTNNToEmitC.cpp` see
-`populateTTNNToEmitCPatterns(...)`.
+`lib/Dialect/TTNN/Transforms/TTNNToCpp.cpp` see
+`TTNNToEmitCOpaqueRewriter<MatmulOp>`.
 
 ## 4. Add a unit test for the Op
 

diff --git a/include/ttmlir/CMakeLists.txt b/include/ttmlir/CMakeLists.txt
@@ -1,4 +1,3 @@
-add_subdirectory(Conversion)
 add_subdirectory(Dialect)
 add_subdirectory(Target)
 add_dependencies(mlir-headers FBS_GENERATION)
diff --git a/include/ttmlir/Conversion/CMakeLists.txt b/include/ttmlir/Conversion/CMakeLists.txt
diff --git a/include/ttmlir/Conversion/Passes.h b/include/ttmlir/Conversion/Passes.h
diff --git a/include/ttmlir/Conversion/Passes.td b/include/ttmlir/Conversion/Passes.td
diff --git a/include/ttmlir/Conversion/TTNNToEmitC/TTNNToEmitC.h b/include/ttmlir/Conversion/TTNNToEmitC/TTNNToEmitC.h
diff --git a/include/ttmlir/Dialect/TTNN/Passes.td b/include/ttmlir/Dialect/TTNN/Passes.td
@@ -21,6 +21,13 @@ def ConvertTTIRToTTNN: Pass<"convert-ttir-to-ttnn", "::mlir::ModuleOp"> {
   }];
 }
 
+def ConvertTTNNToEmitC: Pass<"convert-ttnn-to-emitc", "::mlir::ModuleOp"> {
+  let summary = "";
+  let description = [{
+    todo
+  }];
+}
+
 def TTNNSerializeToBinary: Pass<"ttnn-serialize-to-binary", "::mlir::ModuleOp"> {
   let summary = "";
   let description = [{

diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt
@@ -1,5 +1,4 @@
 add_subdirectory(CAPI)
-add_subdirectory(Conversion)
 add_subdirectory(Dialect)
 
 add_mlir_library(TTMLIR STATIC RegisterAll.cpp

diff --git a/lib/Conversion/CMakeLists.txt b/lib/Conversion/CMakeLists.txt
diff --git a/lib/Conversion/PassDetail.h b/lib/Conversion/PassDetail.h
diff --git a/lib/Conversion/TTNNToEmitC/CMakeLists.txt b/lib/Conversion/TTNNToEmitC/CMakeLists.txt
diff --git a/lib/Conversion/TTNNToEmitC/PopulatePatterns.h b/lib/Conversion/TTNNToEmitC/PopulatePatterns.h
diff --git a/lib/Conversion/TTNNToEmitC/TTNNToEmitC.cpp b/lib/Conversion/TTNNToEmitC/TTNNToEmitC.cpp
diff --git a/lib/Conversion/TTNNToEmitC/TypeConverter.h b/lib/Conversion/TTNNToEmitC/TypeConverter.h
diff --git a/lib/Dialect/TTNN/Transforms/CMakeLists.txt b/lib/Dialect/TTNN/Transforms/CMakeLists.txt
@@ -13,4 +13,3 @@ add_mlir_dialect_library(MLIRTTNNTransforms
         )
 
 target_include_directories(MLIRTTNNTransforms PUBLIC ${PROJECT_BINARY_DIR}/include/ttmlir/Target/Common)
-target_link_libraries(MLIRTTNNTransforms PRIVATE TTMLIRTTNNToEmitC)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,4 +13,3 @@ add_mlir_dialect_library(MLIRTTNNTransforms
		)

		target_include_directories(MLIRTTNNTransforms PUBLIC ${PROJECT_BINARY_DIR}/include/ttmlir/Target/Common)
		target_link_libraries(MLIRTTNNTransforms PRIVATE TTMLIRTTNNToEmitC)