Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#884: Fixed on device perf collection for unary ops and added unit te… #1087

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tapspatel
Copy link
Collaborator

@tapspatel tapspatel commented Oct 28, 2024

…sts for each op for perf mode in ttrt

Apologies for large PR. Large changes related to perf mode.

Major Changes:

  • fixed perf mode for ttnn ops (host side and device side)
  • added perf op tests for each op
  • added better error handling and user feedback
  • fixed ttrt perf api pytests
  • added missing ttrt api pytests
  • uploading of perf results into github artifacts
  • update ttrt documentation for perf via cmd and GUI
  • fixed perf result collection from ttrt run api

closes
#884
#874
#828
#762
#512
#174

Copy link
Contributor

@vmilosevic vmilosevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to CI files look good 👍

Copy link
Contributor

@jnie-TT jnie-TT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime changes look good. Thanks a lot for looking into this!

Copy link
Contributor

@kmabeeTT kmabeeTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Taps, looks great! Couple minor things.

runtime/tools/python/ttrt/common/run.py Outdated Show resolved Hide resolved
runtime/tools/python/ttrt/common/run.py Outdated Show resolved Hide resolved
runtime/lib/ttnn/operations/eltwise/unary.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@kmabeeTT kmabeeTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

@tapspatel tapspatel force-pushed the tpatel/issue-884 branch 2 times, most recently from 6393bc9 to a575331 Compare October 29, 2024 02:16
runtime/tools/python/ttrt/common/run.py Outdated Show resolved Hide resolved
@tapspatel tapspatel force-pushed the tpatel/issue-884 branch 3 times, most recently from 4adbfcd to c342baf Compare October 29, 2024 17:51
@tapspatel tapspatel requested a review from jnie-TT October 29, 2024 17:51
@tapspatel tapspatel merged commit e1ccf6f into main Oct 29, 2024
13 checks passed
@tapspatel tapspatel deleted the tpatel/issue-884 branch November 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants