[Optimizer] Add df and layout overrides #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
odjuricicTT
commented
Nov 4, 2024
odjuricicTT
commented
- Assert if we try to override non existing op.
- Move optimizer overrides to TTNN.
Also move optimizer overrides to TTNN
odjuricicTT
requested review from
nobradovictt,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
jserbedzijaTT,
jnie-TT,
nsmithtt and
mrakitaTT
as code owners
nobradovictt
reviewed
Nov 4, 2024
| @@ -1,18 +1,18 @@ | |||
| // RUN: ttmlir-opt --ttir-to-ttnn-backend-pipeline="system-desc-path=%system_desc_path% enable-optimizer=true memory-layout-analysis-enabled=true override-output-layout=matmul_1=1x8:l1:width_sharded,add_2=1x8:l1:width_sharded,relu_3=1x8:l1:width_sharded,matmul_5=1x1:l1:width_sharded,add_6=1x1:l1:width_sharded,softmax_7=1x1:l1:width_sharded" %s > %t.mlir | |||
| // RUN: ttmlir-opt --ttir-to-ttnn-backend-pipeline="system-desc-path=%system_desc_path% enable-optimizer=true memory-layout-analysis-enabled=true override-output-layout=matmul_1=1x8:l1:width_sharded:row_major:f32,add_2=1x8:l1:width_sharded:row_major:f32,relu_3=1x8:l1:width_sharded:row_major:f32,matmul_5=1x1:l1:width_sharded:row_major:f32,add_6=1x1:l1:width_sharded:row_major:f32,softmax_7=1x1:l1:width_sharded:row_major:f32" %s > %t.mlir | |||
There was a problem hiding this comment.
Is each segment optional or mandatory?
There was a problem hiding this comment.
Everything is mandatory now. Making it optional requires a larger change in how we handle analysis overrides so it will be part of a separate PR.
nobradovictt
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.