[Optimizer] Simple shard layout picker #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobradovictt
requested review from
odjuricicTT,
sdjordjevicTT,
nsmithtt,
rpavlovicTT,
svuckovicTT,
mtopalovicTT,
mrakitaTT and
jserbedzijaTT
as code owners
svuckovicTT
approved these changes
Nov 4, 2024
…match constraint.
nobradovictt
force-pushed
the
nobradovic/sharding_constraints
branch
from
1980a6c to
b452c61
Compare
rpavlovicTT
reviewed
Nov 5, 2024
| @@ -48,6 +48,19 @@ def TT_GridAttr : TT_Attr<"Grid", "grid"> { | |||
| static GridAttr get(::mlir::MLIRContext *context, std::int64_t rank) { | |||
| return GridAttr::get(context, SmallVector<std::int64_t>(rank, 1)); | |||
| } | |||
|
|
|||
| uint64_t mutable cNumUsedCores = 0; | |||
There was a problem hiding this comment.
mutable is used for const attributes, does tablegen create this var as a const?
There was a problem hiding this comment.
Util getter I made is const func and this is used as a cache for result of the getter. I might have gone overboard on this one, but I didn't want to repeat this multiplication for every time getNumUsedCores is invoked.
There was a problem hiding this comment.
Got it. I'd preferably call this gridVolume.
There was a problem hiding this comment.
I was in auto merge mode and didn't stop it, I can rename it in my next change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shard spec constraint within ShardSolver - match shard memory layout on input and output.
Fix height and width shard spec generation.
Add simple shard layout picker.
MNIST is now automatically sharded without overrides!
Closes #1147