[Optimizer] Resharding ON by default. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobradovictt
requested review from
odjuricicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
jserbedzijaTT,
nsmithtt and
mrakitaTT
as code owners
nsmithtt
approved these changes
Nov 5, 2024
nobradovictt
commented
Nov 6, 2024
| uint64_t getNumUsedCores() const { | ||
| if (cNumUsedCores != 0) { | ||
| return cNumUsedCores; | ||
| uint64_t mutable cGridVolume = 0; |
There was a problem hiding this comment.
@rpavlovicTT addressed feedback from previous PR.
nobradovictt
commented
Nov 6, 2024
sdjordjevicTT
approved these changes
Nov 6, 2024
odjuricicTT
approved these changes
Nov 6, 2024
nobradovictt
force-pushed
the
nobradovic/fix_auto_reshard_chain_start
branch
from
49289bf to
91d790a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable resharding to be on by default when Optimizer and Memory layout analysis is enabled.
Reworked conditions for inserting resharding edge on first shard chain op. Assume it's not needed unless it is specified that targeted Op type requires it. Perform preprocessing also in case if resharding edge was passed in as override.
Closes #1161