#1108: Added ability to dump golden data into flatbuffer file for int… #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapspatel
requested review from
nsmithtt,
odjuricicTT,
nobradovictt and
vprajapati-tt
as code owners
tapspatel
force-pushed
the
tpatel/issue-1108
branch
from
a72ff16 to
4c9a9a0
Compare
nsmithtt
approved these changes
Nov 7, 2024
|
Nitpick: broken title |
kmitrovicTT
approved these changes
Nov 7, 2024
so it expands the sentence into the description if the commit message is too long. |
tapspatel
force-pushed
the
tpatel/issue-1108
branch
from
4c9a9a0 to
27d2fe6
Compare
|
fixed all comments. Thanks for the suggestions! |
kmitrovicTT
reviewed
Nov 7, 2024
kmitrovicTT
approved these changes
Nov 7, 2024
nsmithtt
approved these changes
Nov 7, 2024
…ermediate ops and output using python infra for generating ttir modules
tapspatel
force-pushed
the
tpatel/issue-1108
branch
from
27d2fe6 to
737564b
Compare
| @@ -3,5 +3,4 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| from ._ttnn_ops_gen import * | |||
| from ._ttnn_enum_gen import * | |||
There was a problem hiding this comment.
I think we did something weird, I merged in #1194, which assumed this line was kept. I'll make a new PR to keep it in I guess.
There was a problem hiding this comment.
I think this was my bad. I cherry-picked your original code but not the new changes. Lemme know when you put up a new PR and ill approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ermediate ops and output using python infra for generating ttir modules